Merged
Conversation
Contributor
Author
|
The design here is a little different than the Ruby package, so for now I just added the failing test case. I'll come back to this, or someone else can pick it up if they'd like. |
msakrejda
commented
Jun 17, 2025
Contributor
Author
msakrejda
left a comment
msakrejda
left a comment
There was a problem hiding this comment.
Oh cool, thanks for implementing the fix. It looks good to me, but I can't approve since it's my PR.
seanlinsley
approved these changes
Jun 17, 2025
Member
seanlinsley
left a comment
seanlinsley
left a comment
There was a problem hiding this comment.
Looks like I can approve 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See pganalyze/pg_query#336